Skip to content

Changed the game name "Sonic World Adventure" to "Sonic Unleashed" in Japanese installer introduction text #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blueskythlikesclouds merged 3 commits into from
Mar 25, 2025
Merged

Changed the game name "Sonic World Adventure" to "Sonic Unleashed" in Japanese installer introduction text #557

blueskythlikesclouds merged 3 commits into from
Mar 25, 2025

Conversation

@Kuid0us
Copy link
Contributor

@Kuid0us Kuid0us commented Mar 2, 2025

Referring to "Sonic Unleashed" as "Sonic World Adventure" may cause misunderstandings, making it seem as if the JP version of the game is supported.
Additionally, to emphasize the necessity of the NA and EU versions, they should be explicitly mentioned.

@Kuid0us
Update locale.cpp
d52c1dc 
Changed Japanese installer introduction text.
@DeaTh-G DeaTh-G requested a review from brianuuu March 2, 2025 11:19
@brianuuu
Copy link
Contributor

brianuuu commented Mar 2, 2025

image
here's what it will look like, I suggest putting line break before EU and remove line break for the last line

@Kuid0us
Copy link
Contributor Author

Kuid0us commented Mar 2, 2025

Moved the line break. Also, the kanji "北米" doesn't seem to exist in the font. Replaced "北米" with "US".

@brianuuu
Copy link
Contributor

brianuuu commented Mar 2, 2025

nope, you can keep the kanji, those will be recompiled (heh)

@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 2, 2025

Regarding the change to Sonic Unleashed the game's unused installer menu seems to refer to using full capital text. Let's change it to be like that
image

@Kuid0us
Copy link
Contributor Author

Kuid0us commented Mar 2, 2025

Really? I reverted to the kanji.
Capitalization is also applied.

DeaTh-G
DeaTh-G approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@DeaTh-G DeaTh-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now
image

@DeaTh-G DeaTh-G marked this pull request as draft March 4, 2025 08:14
@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 4, 2025

Marked as draft because before merging this will require updates to the https://www.github.com/hedge-dev/UnleashedRecompResources repository too and an update to the submodule.

@DeaTh-G DeaTh-G added this to the v1.0.2 milestone Mar 4, 2025
@hyperbx hyperbx added the resources needed Needs new or updated resources for merging label Mar 6, 2025
@blueskythlikesclouds blueskythlikesclouds modified the milestones: v1.0.2, v1.0.3 Mar 7, 2025
@Kuid0us
Copy link
Contributor Author

Kuid0us commented Mar 11, 2025

Is building the font my task? I don't have an environment to build it because I don't have original font file...

@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 11, 2025

We can build the font on our end we just haven't gotten to this PR yet because there are bigger issues at the moment.

This was referenced Mar 25, 2025
Merged
Merged
@blueskythlikesclouds blueskythlikesclouds marked this pull request as ready for review March 25, 2025 16:31
@blueskythlikesclouds blueskythlikesclouds merged commit e0d3a36 into hedge-dev:main Mar 25, 2025
@d80254480-prog

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeaTh-G DeaTh-G DeaTh-G approved these changes

@brianuuu brianuuu Awaiting requested review from brianuuu

Assignees

No one assigned

Labels

resources needed Needs new or updated resources for merging

Projects

None yet

Milestone

v1.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@Kuid0us @brianuuu @DeaTh-G @d80254480-prog @blueskythlikesclouds @hyperbx