Fix line splitting issues from localization changes #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJSTARbird
approved these changes
Apr 2, 2025
blueskythlikesclouds
approved these changes
Apr 2, 2025
brianuuu
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues in the following locations (the pictures are pre-fix the text explains the fix):
Line is split in the middle of
します, added Japanese line splitting guidance before it.Line is split between
での, to avoid cutting the particles in the middle a split guidance marker was added beforeモード.An unnecessary empty line is inserted. The issue was alleviated by skipping over
\u200Bguidance markers just like\nif a line starts with one after the split logic happens.French localization added an unnecessary space to the English localization here between the colon and
Auto.The colon is split into a different line in French after the necessary space before it was added. A manual line split was added before
par.