Fix DLC info message always being displayed #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a552072 to
9e8d9cb
Compare
9e8d9cb to
1fcb560
Compare
DarioSamo
reviewed
Mar 20, 2025
DarioSamo
reviewed
Mar 20, 2025
DarioSamo
reviewed
Mar 20, 2025
64a5277 to
3ad00fb
Compare
DarioSamo
reviewed
Mar 20, 2025
Contributor
DarioSamo
left a comment
There was a problem hiding this comment.
Code changes seem good to me, still needs validation from someone testing it out.
blueskythlikesclouds
requested changes
Mar 28, 2025
Member
There was a problem hiding this comment.
I don't seem to be able to get achievement data to save when removing the save folder and starting new game, the debug console prints the following output:
[Mod Loader] Loading code: "SkipIntroLogos"
[*] SDL video driver: "windows"
[*] Achievement data will not be saved in this session!
[*] Saving persistent storage binary...
Member
Author
|
Should be fixed now, the condition for it would be missed on first creation due to the default value being if (!ignoreStatus && BinStatus != EAchBinStatus::Success)
{
LOGN_WARNING("Achievement data will not be saved in this session!");
return false;
} |
blueskythlikesclouds
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a game bug that causes the DLC info message to always be displayed. I've explained here the causes of this issue.
Closes #1167.