Skip to content

Conversation

@hjuarez20
Copy link
Contributor

This PR is an extension of #3846 and resolved missing code and conflicts

@LOBsTerr
Copy link
Member

@enzolutions I have reverted my changes, which uses "config:export:entity" as chain command.
I have added it. In order to reduce duplication and make it more easier to export any entity.

$this->chainQueue->addCommand(
            'config:export:entity', [
                'entity-type' => 'node_type',
                'bundle' => $contentType,
                '--module' => $module,
                '--optional-config' => $optionalConfig,
                '--remove-uuid' => $removeUuid,
                '--remove-config-hash' => $removeHash
            ]
        );

@enzolutions
Copy link
Contributor

Hi, @LOBsTerr Do you mean we need to revert this merge? and you will create another PR to introduce your suggestion?

@LOBsTerr
Copy link
Member

I will create a new pr, with the current improvements and my changes

@enzolutions
Copy link
Contributor

Awesome @LOBsTerr

@LOBsTerr
Copy link
Member

@enzolutions Everything should be here: #4044

More information in my new PR: #4045

@enzolutions
Copy link
Contributor

Awesome, we will review an merge soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants