Update composer package type #3447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f08d719 to
0f267fd
Compare
Contributor
|
If composer.lock is removed, this could mean DC can safely require (#3365) |
0f267fd to
9d09691
Compare
Member
|
@gapple Thanks for your contribution, your PR was merged. This will be included on the next release. |
Member
|
@gapple @cburschka Should we send another PR to remove the |
This was referenced Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Drupal Console is now installed as a project requirement instead of as a standalone application, my understanding is that the
typeproperty incomposer.jsonshould be updated.composer.lockis ignored if a package is installed within a project as a dependency.composer create-project drupal/consoleinstead ofcomposer require drupal/console.