cmake: Port PR30263 from the master branch #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
maflcko
approved these changes
Jul 15, 2024
|
ACK ec4c557 |
Owner
Author
|
Rebased. |
fanquake
reviewed
Jul 16, 2024
| export CONTAINER_NAME=ci_native_nowallet_libbitcoinkernel | ||
| export CI_IMAGE_NAME_TAG="docker.io/debian:bullseye" | ||
| # Use minimum supported python3.9 and clang-16, see doc/dependencies.md | ||
| export CI_IMAGE_NAME_TAG="docker.io/ubuntu:24.04" |
There was a problem hiding this comment.
I presume it is needed to bump cmake. I was thinking about bumping python for 29.x, so this will go away in the future anyway. 🤷
There was a problem hiding this comment.
It'd be good if the PR description explained. Rather than claiming to port changes but doing something different for unclear reasons.
Owner
Author
There was a problem hiding this comment.
It'd be good if the PR description explained. Rather than claiming to port changes but doing something different for unclear reasons.
My apologies. The PR description has been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports CI-related changes from bitcoin#30263 and ensures that the minimum required CMake version is available.
Here are CMake versions across all changes: