Clarify Turbo vs Turbolinks requirements#5324
Clarify Turbo vs Turbolinks requirements#5324ghiculescu wants to merge 1 commit intoheartcombo:masterfrom ghiculescu:patch-1
Conversation
Follow up to #4678 I spent a long time digging around the `Turbo` source code looking for a `Turbolinks::Controller` equivalent while trying to do an upgrade, then I realised is no longer necessary.
|
Looks like different configuration is necessary for Turbo: How to use Devise with Hotwire & Turbo.js (Example) | GoRails |
|
|
||
| # ==> Turbolinks configuration | ||
| # If your app is using Turbolinks, Turbolinks::Controller needs to be included to make redirection work correctly: | ||
| # If your app is using Turbolinks (but *not* Turbo), Turbolinks::Controller needs |
There was a problem hiding this comment.
Do we need to tell that Turbolinks is different of Turbo? I thought it was clear by the name that requirements for one are different of the other.
There was a problem hiding this comment.
Maybe it's just me, but I assumed that the requirements would be the same since Turbo (Drive) is being pitched an evolution of Turbolinks.
There was a problem hiding this comment.
If I'm not mistaken this doesn't even work for current (now deprecated) Turbolinks, but only for Turbolinks Classic.
|
I'm gonna close this for now as it looks like it's not that simple, see also hotwired/turbo-rails#34 (cc @bhaibel) |
Follow up to #4678
I spent a long time digging around the
Turbosource code looking for aTurbolinks::Controllerequivalent while trying to do an upgrade, then I realised is no longer necessary.