Skip to content

temp commit.#3

Closed
hdwhdw wants to merge 1 commit intobasefrom
test
Closed

temp commit.#3
hdwhdw wants to merge 1 commit intobasefrom
test

Conversation

@hdwhdw
Copy link
Copy Markdown
Owner

@hdwhdw hdwhdw commented Apr 8, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@hdwhdw hdwhdw requested a review from Copilot April 8, 2025 17:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 23 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • ansible/lab: Language not supported
  • ansible/roles/vm_set/templates/sonic.xml.j2: Language not supported
  • ansible/setup_vs_chassis.sh: Language not supported
  • ansible/templates/vs_chassis_metadata.json.j2: Language not supported
  • ansible/testbed-cli.sh: Language not supported
  • ansible/vars/topo_t2-vs.yml: Language not supported
  • ansible/veos_vtb: Language not supported
Comments suppressed due to low confidence (3)

ansible/roles/vm_set/tasks/start_sonic_vm.yml:19

  • [nitpick] The default value 'pizzabox' for card_type may be inconsistent with other modules or expected defaults (e.g., 'linecard' or 'fixed'). Consider standardizing the default card_type across all relevant playbooks and libraries.
card_type: "{{ hostvars[dut_name]['card_type'] | default('pizzabox') }}"

ansible/library/port_alias.py:217

  • [nitpick] Using 'linecard' as the card_type in this conditional might conflict with default values provided elsewhere (such as 'pizzabox' or 'fixed'). Verify that the intended card_type value is used consistently across the codebase.
if include_internal and card_type == "linecard":

ansible/roles/vm_set/library/vm_topology.py:337

  • [nitpick] Consider including the actual problematic bridge name and the maximum allowed length in the ValueError message to aid debugging (e.g., 'Bridge name {self._vs_chassis_midplane_br_name} exceeds maximum allowed length {MAX_INTF_LEN}').
if len(self._vs_chassis_midplane_br_name) > MAX_INTF_LEN:

@hdwhdw hdwhdw closed this Apr 9, 2025
@hdwhdw hdwhdw deleted the test branch April 22, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants