You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have verified that verilator is working correctly with these changes. Maybe someone can take over from here and ensure other parts of bazel_rules_hdl are not broken. @hovind@UebelAndre@QuantamHD
I will likely continue to try get equivalents to what's in @rules_hdl//dependency_support as granular BCR modules before trying to tackle any rules_hdl rules. That's an area I could use some support as I don't have a use case for everything that's in there. I don't think rules_hdl should care about how things are built, it should just be the rules that wrap various tools so if the logic for building the dependencies can be separated, I think the rules themselves become more standardized. Do you wanna collaborate on getting more of the dependencies into BCR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft of migration to bazel 8 and away from WORKSPACE. Its based on the branch @hovind made that i have modified slightly.
Relevant issues: #336 #210
Revelant PRs: bazelbuild/bazel-central-registry#4341
.bazelrcconfigMODULE.bazelsnippetI have verified that verilator is working correctly with these changes. Maybe someone can take over from here and ensure other parts of bazel_rules_hdl are not broken.
@hovind @UebelAndre @QuantamHD