Dev0934 增加 ShadowCandidate UniquifiedCandidate#162
Merged
hchunhui merged 22 commits intohchunhui:masterfrom Jul 11, 2022
Merged
Dev0934 增加 ShadowCandidate UniquifiedCandidate#162hchunhui merged 22 commits intohchunhui:masterfrom
hchunhui merged 22 commits intohchunhui:masterfrom
Conversation
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
* add EngineReg select_schema() env.engine:select( string schema_id ) .next Signed-off-by: shewer <shewer@gmail.com> * add engine:apply_schema( Schema &) Schema( const string &) Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: Shewer Lu <shewer@gmail.com>
Signed-off-by: Shewer Lu <shewer@gmail.com>
Signed-off-by: Shewer Lu <shewer@gmail.com>
Signed-off-by: Shewer Lu <shewer@gmail.com>
Signed-off-by: Shewer Lu <shewer@gmail.com>
hchunhui
reviewed
Jul 11, 2022
| { "get_genuine", WRAP(T::GetGenuineCandidate) }, | ||
| { "get_genuines", WRAP(T::GetGenuineCandidates) }, | ||
| { "to_shadow_candidate", WRAP(shadow_candidate) }, | ||
| { "to_uniquified_candidate", WRAP(uniquified_candidate) }, |
Owner
There was a problem hiding this comment.
to_shadow_candidate 和 to_uniquified_candidate 是否写错，作为 method 为何与 ShadowCandidate 和 UniquifiedCandidate 相同？
Contributor
Author
There was a problem hiding this comment.
to_shadow_candidate to_uniquified_candidate
調用 c api 是相 同 的 參數
只是方便 instance 使用 : 來調用
cand:to_shadow_candidate(type,text,comment)
和 Shadow_Candidate(cand,type,text,comment)
是同個恴思
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
可解決SimpleCandidate commit 無法更新user_dictionary 問題
ShadowCandidate(cand,type,text,comment)類似 simplifier 的作法
UniqifiedCandidate(cand,type,text,comment) 類似 uniqifier 的l作法