Skip to content

fix #71: fix revert#72

Merged
hchiam merged 1 commit into
mainfrom
fix-revert
Feb 5, 2022
Merged

fix #71: fix revert#72
hchiam merged 1 commit into
mainfrom
fix-revert

Conversation

@hchiam

@hchiam hchiam commented Feb 5, 2022

Copy link
Copy Markdown
Owner

Problem/Need:

revert the revert to actually fix #68

Suggested changes:

Reminders for @hchiam:

@hchiam hchiam added bug Something isn't working priority Do first labels Feb 5, 2022
@hchiam hchiam self-assigned this Feb 5, 2022
Comment thread index.js
}

function animateMove(originJQueryElement, destinationJQueryElement) {
destinationJQueryElement.css("visibility", "hidden");

@hchiam hchiam Feb 5, 2022

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a lot of changes, but actually just removing the outer-wrapping setTimeout of 300 ms

@hchiam hchiam left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@hchiam hchiam merged commit 991d7c7 into main Feb 5, 2022
@hchiam hchiam deleted the fix-revert branch February 5, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority Do first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get rid of the animation changing sizes/timing (caused usability issues)

1 participant