Fix modal layout #9980
Merged
Fix modal layout #9980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes modal layout by making the maximum width configurable instead of using a hardcoded CSS value. The change allows individual modals to specify their own maximum width while maintaining backward compatibility.
- Adds a configurable
maxWidthproperty to the Modal component - Updates CreateCardPopup to use the new max-width property
- Removes the hardcoded
max-width: 90vwfrom the global modal CSS
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CreateCardPopup.svelte | Sets max-width="90vw" using the new property |
| Modal.svelte | Adds maxWidth prop and applies it as inline style |
| components.scss | Removes hardcoded max-width from modal container |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Connected to Huly®: UBERF-13818 |
BykhovDenis
previously approved these changes
Sep 30, 2025
haiodo
previously approved these changes
Sep 30, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
e8862a8
haiodo
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.