qfix: handle outside clicks only when popup is top level #9972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
|
Connected to Huly®: UBERF-13810 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where outside clicks would close popup windows even when they weren't the topmost popup in the stack. The fix ensures that only the top-level popup responds to outside click events.
- Added popup ID tracking to identify when a popup is the topmost in the stack
- Modified click handler to only close popup when it's the current top-level popup
- Refactored import structure to use local plugin reference
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| documentComments.ts | Added popup ID configuration and refactored imports to support popup hierarchy tracking |
| plugin.ts | Added AddCommentPopup ID resource definition for popup identification |
| AddCommentPopup.svelte | Implemented top-level popup detection logic to prevent inappropriate closure on outside clicks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
plugins/controlled-documents-resources/src/stores/editors/document/documentComments.ts
Show resolved
Hide resolved
plugins/controlled-documents-resources/src/components/document/popups/AddCommentPopup.svelte
Outdated
Show resolved
Hide resolved
lexiv0re
previously approved these changes
Sep 29, 2025
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lexiv0re
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.