Backport plugin permissions in the workspace #9966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
|
Connected to Huly®: UBERF-13804 |
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restores permission-based restrictions from v6 by implementing a comprehensive permissions system to forbid creation of certain workspace entities. It introduces workspace-level permissions that prevent users from creating projects, teamspaces, drives, funnels, and vacancies.
- Implements workspace-scoped permission checking in the middleware
- Adds new "forbid" permissions for create operations on major entity types
- Updates UI components to use a unified HeaderButton with permission-aware actions
Reviewed Changes
Copilot reviewed 85 out of 87 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| server/middleware/src/spacePermissions.ts | Refactors permission checking to support workspace permissions with forbid logic |
| plugins/*/src/index.ts | Adds permission definitions and string constants for forbid create permissions |
| models/*/src/permissions.ts | Defines workspace-level forbid permissions for entity creation |
| plugins/*-resources/src/components/*Header.svelte | Replaces custom button implementations with unified HeaderButton component |
| packages/ui/src/components/HeaderButton.svelte | New unified header button component with permission checking |
| tests/sanity/tests/**/*.ts | Updates test selectors from generic IDs to specific string constants |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lexiv0re
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore permissions from v6: