Fixed single desktop app instance handling. #9958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
|
Connected to Huly®: UBERF-13796 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes single desktop app instance handling on Windows by moving the single-instance lock acquisition to the beginning of the application startup process. This prevents crashes when launching a second instance and eliminates window flickering issues with jump list elements.
- Moved single-instance lock and quit logic to the top of the startup file for early termination
- Introduced a consistent
quitApplicationfunction to replace directapp.quit()calls - Fixed a minor switch-case issue by replacing
returnwithbreakin the default clause
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| desktop/src/main/start.ts | Restructured app initialization by moving single-instance handling to top and wrapping main logic in runTheApp() function |
| desktop/src/main/windowsSpecificSetup.ts | Fixed switch-case default clause to use break instead of return |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lexiv0re
approved these changes
Sep 27, 2025
BykhovDenis
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, launching a second instance didn't even reach the lock acquisition - the application crashed earlier. Now there are no console errors when launching the second application. And there's no window flickering when selecting jump list elements. The main window is also correctly displayed when launching a second instance.
In start.ts, the real changes are only at the beginning of the file. Everything else that was touched is just indentation, in order to 'wrap' all the code into a function.
Application startup and quit logic improvements:
app.requestSingleInstanceLock()) and related quit logic to the top of the startup file, ensuring the application quits early if another instance is running. ThequitApplicationfunction is now used consistently for quitting the app. [1] [2] [3] [4]app.quit()to use the newquitApplicationfunction, ensuring consistent handling of theisQuitingflag across the codebase. [1] [2]Other improvements:
desktop/src/main/windowsSpecificSetup.tsby replacing areturnstatement with abreakin a switch-case default clause for better code clarity and correctness.