Fix threads and attachments overflow for large messages #9950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-13788 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes overflow issues with threads and attachments in large messages by relocating the ShowMore component from the message presenter level to the content viewer level for more precise control over content expansion.
- Moved ShowMore component from MessagePresenter to MessageContentViewer for targeted content overflow handling
- Added collapsible and maxHeight props to enable fine-grained control over message expansion behavior
- Enhanced styling to properly position ShowMore controls within message containers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| MessagePresenter.svelte | Removed ShowMore wrapper and passed through collapsible/maxHeight props |
| MessageContentViewer.svelte | Added ShowMore component around content with configurable parameters |
| MessageBody.svelte | Added props for collapsible behavior and styling for ShowMore positioning |
| ShowMore.svelte | Converted bigger from internal state to exportable prop for external binding |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
plugins/communication-resources/src/components/message/MessageContentViewer.svelte
Outdated
Show resolved
Hide resolved
plugins/communication-resources/src/components/message/MessageContentViewer.svelte
Outdated
Show resolved
Hide resolved
plugins/communication-resources/src/components/message/MessageContentViewer.svelte
Outdated
Show resolved
Hide resolved
haiodo
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: