Fix ctrl-w handling even in background. #9925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
|
Connected to Huly®: UBERF-13762 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Ctrl+W hotkey handling so it only works when the main window is focused, preventing background interference. The change moves global shortcut registration from application startup to window focus events.
- Moves global shortcut registration from app startup to window focus/blur events
- Adds proper cleanup of global shortcuts when the window loses focus or app quits
- Extracts the hotkey constant to a shared location for better maintainability
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aonnikov
previously approved these changes
Sep 23, 2025
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
haiodo
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unregistering the shortcut when main window loses focus.