Desktop app for Windows: fixed tray icon on low DPI screens. #9917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
|
Connected to Huly®: UBERF-13754 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes tray icon display issues on low DPI screens for the Windows desktop app by simplifying the badge icon system. Instead of using multiple PNG files with dynamic badge counts, the implementation now uses a single ICO file for all badge states.
- Simplified badge icon logic to use a single
TrayIconWithBadge.icofile regardless of badge count - Removed complex file path construction and badge count-specific icon selection
- Updated tests to reflect the new unified icon approach
Reviewed Changes
Copilot reviewed 3 out of 104 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| desktop/src/main/trayUtils.ts | Simplified getBadgeIconInfo function to return single icon file for all badge counts |
| desktop/src/main/tray.ts | Removed path.join usage and subdirectory reference for icon loading |
| desktop/src/test/main/trayUtils.test.ts | Updated test expectations to match new single icon file behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aonnikov
approved these changes
Sep 23, 2025
BykhovDenis
approved these changes
Sep 23, 2025
ArtyomSavchenko
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly tray icons on low res display have been fixed: deleted icons for every notifications count; added single ICO file with images for every screen resolution.