UBERF-13692: Adjut merge contacts to global accounts #9911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
|
Connected to Huly®: UBERF-13748 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts merge contact functionality to integrate with global accounts by refactoring the person merging logic from service operations to regular operations and enhancing the UI to support social identity merging and validation.
Key changes:
- Moved person merging functions from service operations to regular operations with enhanced validation
- Enhanced the merge persons UI to display social identities and check merge eligibility
- Added a new SocialIdentityPresenter component for consistent social identity display
- Added infrastructure for Redis and HulyPulse services
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/account/src/serviceOperations.ts | Removed mergeSpecifiedPersons function and related imports/exports |
| server/account/src/operations.ts | Added canMergeSpecifiedPersons and mergeSpecifiedPersons functions with validation |
| plugins/setting-resources/src/components/socialIds/SocialIdsEditor.svelte | Updated to use new SocialIdRow component |
| plugins/setting-resources/src/components/socialIds/SocialIdRow.svelte | Refactored to use SocialIdentityPresenter component |
| plugins/contact-resources/src/visibilityTester.ts | Added canMergePersons visibility tester |
| plugins/contact-resources/src/plugin.ts | Added CannotMerge string and CanMergePersons function |
| plugins/contact-resources/src/index.ts | Exported SocialIdentityPresenter and canMergePersons |
| plugins/contact-resources/src/components/SocialIdentityPresenter.svelte | New component for displaying social identity information |
| plugins/contact-resources/src/components/MergePersons.svelte | Enhanced merge dialog with social identity handling and validation |
| plugins/contact-assets/lang/*.json | Added CannotMerge error message translations |
| packages/account-client/src/client.ts | Added canMergeSpecifiedPersons method |
| models/contact/src/plugin.ts | Added SocialIdentityPresenter component reference |
| models/contact/src/index.ts | Added presenter configuration and visibility tester |
| dev/docker-compose.min.yaml | Added Redis and HulyPulse services |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
haiodo
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://front.hc.engineering/workbench/platform/tracker/UBERF-13692