fix: refactor presence and typing to use svelte actions #9908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
|
Connected to Huly®: UBERF-13743 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors presence and typing functionality to use Svelte actions instead of manual subscription management. This provides a more declarative approach and cleaner component code by handling subscription lifecycle automatically through the action pattern.
- Introduces new Svelte action functions (
presenceandtyping) with parameter interfaces - Converts components to use the new actions instead of manual subscription handling
- Removes manual lifecycle management code from components
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/presence-resources/src/typing.ts | Adds TypingActionParams interface and typing Svelte action function |
| plugins/presence-resources/src/presence.ts | Adds PresenceActionParams interface and presence Svelte action function |
| plugins/presence-resources/src/components/PresenceAvatars.svelte | Refactored to use the new presence action instead of manual subscription |
| plugins/communication-resources/src/components/TypingPresenter.svelte | Refactored to use the new typing action instead of manual subscription |
| plugins/chunter-resources/src/components/ChannelTypingInfo.svelte | Refactored to use the new typing action instead of manual subscription |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
kristina-fefelova
approved these changes
Sep 22, 2025
haiodo
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.