EQMS-1618: Fix server branding #9907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
|
Connected to Huly®: UBERF-13742 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes server branding functionality by properly retrieving and passing branding information from workspace configurations throughout the authentication and session management flow.
- Updates branding retrieval logic to use the branding map instead of hardcoded null value
- Adds branding field to workspace information interfaces and operations
- Configures development environment with branding path
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/server/src/sessionManager.ts | Implements branding lookup from branding map and includes branding in workspace response |
| server/account/src/types.ts | Adds optional branding field to LoginInfoWorkspace interface |
| server/account/src/operations.ts | Includes branding field in workspace login information |
| packages/account-client/src/types.ts | Adds optional branding field to client-side LoginInfoWorkspace interface |
| .vscode/launch.json | Adds BRANDING_PATH environment variable for development configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
haiodo
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://front.hc.engineering/workbench/platform/tracker/EQMS-1618