Office: refactor meeting creation #9905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
|
Connected to Huly®: UBERF-13741 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors meeting creation and management by extracting meeting-related logic into dedicated controller and client classes, improving code organization and separation of concerns.
Key changes include:
- Introduction of
MeetingControllerandLoveClientfor centralized meeting operations - Simplified
LiveKitClientfocused solely on media session management - Removal of redundant functions and state management logic from utils
Reviewed Changes
Copilot reviewed 39 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/love-resources/src/utils.ts | Removed meeting connection logic and duplicated functions, simplified exports |
| plugins/love-resources/src/meetingController.ts | New controller managing meeting lifecycle operations and participant interactions |
| plugins/love-resources/src/loveClient.ts | New client class for Love service API interactions |
| plugins/love-resources/src/liveKitClient.ts | Refactored to focus on media session management with improved event handling |
| plugins/love-resources/src/components/meeting/invites/InviteEmployeeButton.svelte | New component for employee invitation functionality |
Comments suppressed due to low confidence (2)
plugins/love-resources/src/utils.ts:309
- The parameters
_idand_datause underscore prefixes suggesting they are unused. If these parameters are truly unused, consider removing them or renaming them without underscores if they serve a purpose.
export async function createMeeting (
client: TxOperations,
_id: Ref<Event>,
space: Space,
_data: Data<Event>,
store: Record<string, any>,
phase: DocCreatePhase
): Promise<void> {
plugins/love-resources/src/utils.ts:337
- Similar to the previous function, parameters
_idand_datause underscore prefixes suggesting they are unused. Consider removing them or renaming them appropriately.
export async function createMeetingSchedule (
client: TxOperations,
_id: Ref<Schedule>,
space: Space,
_data: Data<Schedule>,
store: Record<string, any>,
phase: DocCreatePhase
): Promise<void> {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
plugins/love-resources/src/components/meeting/controls/RecordingButton.svelte
Outdated
Show resolved
Hide resolved
plugins/love-resources/src/components/meeting/controls/RecordingButton.svelte
Outdated
Show resolved
Hide resolved
plugins/love-resources/src/components/RoomLanguageSelector.svelte
Outdated
Show resolved
Hide resolved
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
haiodo
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.