fix: use pulse for presence avatars #9896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
|
Connected to Huly®: UBERF-13732 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the presence system to use the pulse client for real-time updates instead of the previous implementation. It introduces separate modules for typing and presence functionality while removing legacy presence management code.
- Refactors presence system to use pulse client for real-time communication
- Separates typing and presence functionality into dedicated modules
- Updates components to use new pulse-based presence subscription system
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/presence-resources/src/typing.ts | New module implementing pulse-based typing functionality |
| plugins/presence-resources/src/store.ts | Removes legacy presence management and derived stores |
| plugins/presence-resources/src/pulse.ts | Removes typing functionality (moved to dedicated module) |
| plugins/presence-resources/src/presence.ts | New module implementing pulse-based presence functionality |
| plugins/presence-resources/src/index.ts | Updates exports to include new presence and typing modules |
| plugins/presence-resources/src/components/PresenceContext.svelte | Refactors to use new pulse-based presence updates with TTL |
| plugins/presence-resources/src/components/PresenceAvatars.svelte | Refactors to use new presence subscription system |
| plugins/communication-resources/src/components/message/MessageInput.svelte | Adds void to clearTyping call |
| plugins/chunter-resources/src/components/chat-message/ChatMessageInput.svelte | Adds void to typing function calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ArtyomSavchenko
approved these changes
Sep 19, 2025
lleokaganov
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.