-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Combine into one application chat, inbox and home #9865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-13703 |
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates three applications (chat, inbox, and home) into a single unified chat application. The change removes the separate inbox and home plugins while integrating their functionality into the existing chat application.
Key changes:
- Removed all inbox and home related packages from the monorepo
- Updated the chat application to include inbox functionality
- Modified notification handling to use the chat application instead of inbox
Reviewed Changes
Copilot reviewed 147 out of 158 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rush.json | Removed package entries for inbox and home related modules |
| plugins/workbench-resources/src/components/Applications.svelte | Updated notification references to use chatId instead of inboxId |
| plugins/chat/src/index.ts | Added inbox-related strings and icons to chat plugin |
| plugins/chat-resources/ | Enhanced chat components to include inbox functionality |
| models/all/ | Removed inbox and home model references |
| dev/prod/ | Removed inbox and home imports and configurations |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Before:



After: