fix: use pulse typing in communication chat #9844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: UBERF-13680 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the typing presence system in communication chat from using a presence-based approach to a pulse-based approach with proper typing notifications.
- Replaces presence-based typing with pulse client typing system
- Consolidates typing functionality from multiple plugins into a single approach
- Improves data serialization and error handling for typing notifications
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/presence-resources/src/pulse.ts | Refactors typing functions to use Person references instead of social IDs and improves error handling |
| plugins/communication-resources/src/types.ts | Removes duplicate PresenceTyping interface |
| plugins/communication-resources/src/components/message/MessageInput.svelte | Updates to use new pulse typing functions |
| plugins/communication-resources/src/components/TypingPresenter.svelte | Refactors to use pulse subscription instead of presence system |
| plugins/chunter-resources/src/types.ts | Removes entire file containing duplicate PresenceTyping interface |
| plugins/chunter-resources/src/components/chat-message/ChatMessageInput.svelte | Simplifies by removing unused typing array |
| plugins/chunter-resources/src/components/ChannelTypingInfo.svelte | Updates to use new pulse-based typing with improved error handling |
| packages/hulypulse-client/src/client.ts | Updates message handling to properly serialize/deserialize JSON data |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
968821b to
1ad07a5
Compare
kristina-fefelova
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.