Add search for card types dropdown #9836
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-13652 |
|
Maybe we can add some titles, or somehow redesign the dialog to explain users what all these options mean. |
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds search functionality to card type dropdown menus, enabling users to filter nested dropdown items by typing. The search feature includes internationalization support and uses caching for performance optimization.
Key Changes
- Added search input field to nested dropdown menus with
withSearchprop - Implemented
LocalizedSearchclass with translation caching for filtering internationalized dropdown items - Added comprehensive test coverage for the search functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| TypeSelector.svelte | Enables search functionality and disables focus on mouseover for card type dropdown |
| search.ts | New LocalizedSearch class for filtering dropdown items with translation support |
| NestedMenu.svelte | Integrates search functionality with filtered items display and empty state handling |
| NestedDropdown.svelte | Passes through search-related props to nested menu component |
| search.test.ts | Comprehensive test coverage for LocalizedSearch functionality |
| location.test.ts | Adds Jest mocks for svelte/store to prevent ES module issues |
| package.json | Adds test scripts for the UI package |
| jest.config.js | Updates Jest configuration for proper testing environment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
We discussed it and decided to leave it as is for now |
Uh oh!
There was an error while loading. Please reload this page.