Fix old inbox notifications #9835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-13637 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes old inbox notifications by refactoring the notification handling system to centralize props and behaviors. The change removes duplicated notification logic and introduces a custom app props system to handle special cases like the inbox application.
- Centralizes inbox-specific properties and click behavior into a reactive statement
- Replaces hardcoded notification properties with a customizable props system
- Maintains backward compatibility while improving code maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Workbench.svelte | Centralizes inbox props definition and passes custom app props to Applications component |
| Applications.svelte | Adds support for custom app props with fallback to default behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Artem Savchenko <armisav@gmail.com>
aonnikov
previously approved these changes
Sep 11, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
haiodo
approved these changes
Sep 11, 2025
BykhovDenis
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.