UBERF-13511: Support guest tokens with open account #9834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
|
Connected to Huly®: UBERF-13636 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for guest tokens with open accounts by introducing time-based access controls and personalization options. It enables guest access links that can be time-limited and either personalized for a single user or shareable for multiple users.
- Adds
notBefore,expiration, andsub(subject) fields to tokens for time-based access control - Introduces
personalizedparameter to control whether access links are for single-user or multi-user access - Updates frontend to handle token expiration and "not yet active" states with appropriate user feedback
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/token/src/token.ts | Core token structure changes and generation logic for time-based fields |
| server/account/src/utils.ts | Token handling updates in workspace selection and guest account management |
| server/account/src/operations.ts | Access link creation with time validation and personalization options |
| plugins/login-resources/src/plugin.ts | New status codes and strings for token expiration handling |
| plugins/login-resources/src/components/Auth.svelte | Frontend handling of expired and not-yet-active tokens with countdown display |
| plugins/login-assets/lang/*.json | Localized strings for access expiration messages across multiple languages |
| packages/ui/src/components/TimeLeft.svelte | Enhanced time display component with hours support and day formatting |
| packages/platform/src/platform.ts | New platform status codes for token state validation |
| packages/account-client/src/client.ts | Client API updates for new access link options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
BykhovDenis
previously approved these changes
Sep 11, 2025
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
haiodo
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notBefore,expirationand parameters to grant access only during specified period of timepersonalizedparam to control whether the access link should be personalized or could be used by multiple peopleRelated to: https://front.hc.engineering/workbench/platform/tracker/UBERF-13511
Closes #9789