UBERF-13510: Card space public link #9804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: UBERF-13542 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new menu action to share personalized public links to card spaces, enabling users to generate access links with specific space permissions for Guest users.
- Extends token and permission system to support space-scoped access grants
- Implements public link generation for card spaces with proper validation
- Adds localized UI strings and actions for the new functionality
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| server/token/src/token.ts | Adds grantedBy field and changes spaces type to string array in PermissionsGrant |
| server/server/src/client.ts | Updates session to return grantedBy and properly type spaces array |
| server/account/src/operations.ts | Extends createAccessLink to accept spaces parameter and adds grantedBy validation |
| server-plugins/contact-resources/src/index.ts | Implements space access validation logic with grantor verification |
| plugins/view/src/utils.ts | Moves canCopyLink utility function to view package |
| plugins/view-resources/src/utils.ts | Removes canCopyLink function (moved to view package) |
| plugins/card/src/index.ts | Adds new action strings and function definitions |
| plugins/card-resources/src/utils.ts | Implements core logic for generating space access public links |
| plugins/card-resources/package.json | Adds required dependencies for login and account-client |
| plugins/card-assets/lang/*.json | Adds localized strings for "Get personalized public link" |
| packages/core/src/utils.ts | Updates PermissionsGrant interface to include grantedBy field |
| packages/account-client/src/client.ts | Updates createAccessLink API to accept options object with spaces |
| models/card/src/index.ts | Defines new context menu action for card spaces |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d578e70 to
f273f92
Compare
utkaka
previously approved these changes
Sep 9, 2025
haiodo
previously approved these changes
Sep 9, 2025
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com> Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com> Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com> Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com> Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com> Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
692a00f to
0b22e27
Compare
haiodo
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://front.hc.engineering/workbench/platform/tracker/UBERF-13510
Closes #9788