UBERF-10382 Support preview for HEIC and BMP #9790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
|
Connected to Huly®: UBERF-13512 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for previewing HEIC and BMP image formats by converting them to PNG. The implementation introduces conversion utilities for both formats and integrates them into the existing image preview provider.
- Adds HEIC to PNG conversion using the heic-decode library
- Adds BMP to PNG conversion using the bmp-ts library with manual RGBA channel reordering
- Updates the ImageProvider to handle HEIC/HEIF and BMP content types
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pods/preview/src/utils/heic.ts | New utility for converting HEIC files to PNG format |
| pods/preview/src/utils/bmp.ts | New utility for converting BMP files to PNG with RGBA channel correction |
| pods/preview/src/providers/image.ts | Updated image provider to handle HEIC/HEIF and BMP conversions |
| pods/preview/package.json | Added dependencies for heic-decode and bmp-ts libraries |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
haiodo
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unsupported format issues for bmp and heic images