UBERF-13507: Support space membership via token claim #9786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
|
Connected to Huly®: UBERF-13508 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for space membership via token claims, allowing specific spaces to be granted access through authentication tokens. The implementation extends the token system to include space references and automatically adds users to specified spaces during employee creation.
- Extends token structure to include optional space references in permissions grants
- Modifies token generation and decoding to handle space membership claims
- Updates employee creation logic to automatically add users to token-specified spaces
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/token/src/token.ts | Adds spaces field to PermissionsGrant interface and token generation |
| server/server/src/client.ts | Implements method to extract permissions grant from token and pass to session context |
| server/middleware/src/triggers.ts | Updates middleware to pass grant information to session context |
| server/core/src/utils.ts | Adds PermissionsGrant import and grant field to SessionDataImpl |
| server/account/src/utils.ts | Updates workspace selection to extract and pass grant information from tokens |
| server-plugins/contact-resources/src/index.ts | Modifies employee creation to add users to spaces specified in token grants |
| packages/core/src/utils.ts | Defines PermissionsGrant interface with optional spaces array |
| packages/core/src/server.ts | Adds grant field to SessionData interface |
| .vscode/launch.json | Updates model version from 0.7.186 to 0.7.230 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
utkaka
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://front.hc.engineering/workbench/platform/tracker/UBERF-13507
Closes #9785