Drawing board undo/redo and bug fixes #9726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GeneralGDA
commented
Aug 27, 2025
- Undo/redo support.
- Canvas resize fix (drawing above an image).
- Tooltips.
- Text editing commit on tool selection.
- Collaborative drawing board: dark background when dark theme selected.
- Basic module tests for drawing board.
- Refactoring: stricter typing.
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
…sting Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
|
Connected to Huly®: UBERF-13307 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive undo/redo functionality for the drawing board along with numerous bug fixes and improvements. It introduces proper type safety, collaborative features, and better user experience through tooltips and accessibility enhancements.
Key changes include:
- Added undo/redo support using Yjs UndoManager with a new DrawingCommandsProcessor class
- Fixed canvas resizing issues when drawing above images through improved CSS transform scaling
- Enhanced the drawing board with tooltips for all tools and better theme support for dark mode
- Improved type safety by introducing CommandUid branded type and stricter typing throughout
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
packages/presentation/src/drawingCommandsProcessor.ts |
New class managing undo/redo operations with Yjs integration |
packages/presentation/src/drawingUtils.ts |
New utilities for point manipulation and canvas scaling calculations |
packages/presentation/src/drawing.ts |
Major refactor with stricter typing, improved canvas scaling, and undo/redo integration |
packages/presentation/src/components/DrawingBoardToolbar.svelte |
Added undo/redo buttons and tooltips for all tools |
packages/theme/styles/_colors.scss |
Theme-aware drawing background colors for light/dark modes |
| Language files | Added localized strings for new UI elements and tooltips |
| Test files | Comprehensive test coverage for new drawing utilities and command processor |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
Signed-off-by: Denis Gladkiy <denis.gladkiy@hardcoreeng.com>
ArtyomSavchenko
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.