Refactor handling media devices & permissions #9718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
|
Connected to Huly®: UBERF-13282 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the media device and permissions handling system to address browser-specific issues, particularly with Firefox. The changes centralize device management, improve permission requests, and handle device availability during active sessions.
Key changes include:
- Replaces the
enumerateDevicesfunction with a newgetMediaDevicesfunction that handles permissions more intelligently - Consolidates device selection logic by removing separate getter functions and integrating them into the main media info structure
- Updates all media-related components to use the new centralized device management approach
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/media/src/utils.ts | Introduces new getMediaDevices function and MediaInfo interface, removes old enumeration logic |
| plugins/media-resources/src/utils.ts | Removes separate device getter functions, updates useMedia to be async and use new device management |
| plugins/media-resources/src/components/*.svelte | Updates media popup components to accept MediaInfo prop instead of fetching devices individually |
| plugins/love-resources/src/liveKitClient.ts | Integrates new media device management into LiveKit connection flow |
| plugins/love-resources/src/utils.ts | Removes old device management functions, updates screen sharing calls |
| plugins/recorder-resources/src/components/RecordingPopup.svelte | Updates to use new getMediaDevices function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
aonnikov
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.