fix: limit clone depth #9716
Merged
fix: limit clone depth #9716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a clone depth limit mechanism to prevent potential stack overflow or performance issues from deeply nested object cloning. The changes modify the clone function to accept a depth parameter and stop cloning when the depth limit is reached.
- Added depth parameter to the
clonefunction with a default value of 5 - Updated the Hierarchy class to explicitly pass a depth limit of 5 when cloning
- Added comprehensive test coverage for the new depth limiting functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/clone.ts | Added depth parameter and depth checking logic to prevent infinite recursion |
| packages/core/src/hierarchy.ts | Updated clone call to explicitly pass depth limit of 5 |
| packages/core/src/tests/clone.test.ts | Added comprehensive test suite covering clone functionality and depth limiting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
haiodo
reviewed
Aug 25, 2025
haiodo
suggested changes
Aug 25, 2025
Contributor
haiodo
left a comment
There was a problem hiding this comment.
Please support old behaviour
|
Connected to Huly®: UBERF-13269 |
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
haiodo
previously approved these changes
Aug 25, 2025
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
haiodo
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.