UBERF-13241: Support gmail space config #9710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-13252 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for gmail space configuration, allowing users to select a specific space where Gmail messages should be stored instead of using only PersonSpace. It introduces a v2 configuration system that requires users to explicitly configure their Gmail integration.
- Adds space configuration functionality to Gmail integration with backwards compatibility
- Introduces version-aware integration handling (v2 requires space configuration)
- Updates type system to use generic Space instead of PersonSpace throughout the codebase
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/mail/mail-common/src/types.ts | Updates type definitions to use generic Space instead of PersonSpace |
| services/mail/mail-common/src/thread.ts | Updates ThreadLookupService to work with generic Space references |
| services/mail/mail-common/src/personSpaces.ts | Modifies PersonSpacesCache to return generic Space array |
| services/mail/mail-common/src/message.ts | Updates message creation logic to support configurable space selection |
| services/mail/mail-common/src/channel.ts | Updates ChannelCache to work with generic Space references |
| services/gmail/pod-gmail/src/utils.ts | Adds utility function to extract spaceId from integration config |
| services/gmail/pod-gmail/src/types.ts | Adds isConfigured field to SyncState interface |
| services/gmail/pod-gmail/src/main.ts | Adds new /start-sync endpoint for manual sync triggering |
| services/gmail/pod-gmail/src/integrations.ts | Updates integration creation with version information |
| services/gmail/pod-gmail/src/gmailController.ts | Adds startSyncForClient method for targeted sync operations |
| services/gmail/pod-gmail/src/gmail.ts | Implements configuration validation and space-aware sync logic |
| plugins/gmail/src/index.ts | Adds isConfigured field to GmailSyncState interface |
| plugins/gmail-resources/src/utils.ts | Adds utility to detect new Gmail integration version |
| plugins/gmail-resources/src/plugin.ts | Adds new localization strings for configuration UI |
| plugins/gmail-resources/src/components/icons/GmailColor.svelte | Adds size prop to Gmail icon component |
| plugins/gmail-resources/src/components/IntegrationState.svelte | Updates integration state display for configuration status |
| plugins/gmail-resources/src/components/ConfigureV2.svelte | New component for v2 Gmail integration configuration |
| plugins/gmail-resources/src/components/Configure.svelte | Updates to route between v1 and v2 configuration |
| plugins/gmail-resources/src/api.ts | Adds startSync API function |
| plugins/gmail-resources/package.json | Adds card package dependency |
| plugins/gmail-assets/lang/*.json | Adds localization strings in multiple languages |
| packages/integration-client/src/utils.ts | Adds utility to extract integration configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Artem Savchenko <armisav@gmail.com>
haiodo
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.