fix: properly close iterators #9705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
|
Connected to Huly®: UBERF-13188 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes proper cleanup of iterators by ensuring they are closed in finally blocks to prevent resource leaks. The changes address iterator resource management issues across multiple files.
- Wrap iterator usage in try-finally blocks to guarantee proper cleanup
- Fix typos in error messages from "failed t oclean all objecrs" to "failed to clean all objects"
- Reorganize iterator creation to be closer to usage in migration functions
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/s3/src/index.ts | Fixes typo in error message |
| server/minio/src/index.ts | Fixes typo in error message |
| packages/storage/src/index.ts | Adds try-finally blocks to ensure iterator cleanup in removeAllObjects and objectsToArray |
| models/server-activity/src/migration.ts | Wraps document iteration in try-finally for proper cleanup |
| models/contact/src/migration.ts | Moves iterator creation closer to usage |
| dev/tool/src/storage.ts | Ensures both iterators are closed properly |
| dev/tool/src/clean.ts | Adds try-finally block for iterator cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
haiodo
approved these changes
Aug 20, 2025
lexiv0re
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.