fix: datalake cache memory leaks #9699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
|
Connected to Huly®: UBERF-13139 |
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes memory leaks in the datalake cache system by implementing proper stream resource cleanup and improving cache key management.
- Adds proper stream cleanup with
destroy()calls in finally blocks - Migrates from callback-based
pipelineto promise-basedstream/promisesversion - Refactors cache keys to include workspace UUID for better isolation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/datalake/pod-datalake/src/handlers/image.ts | Implements stream cleanup, refactors pipeline usage, and updates cache key generation to include workspace |
| services/datalake/pod-datalake/src/datalake/datalake.ts | Adds stream cleanup and consolidates cache size checking logic |
| services/datalake/pod-datalake/src/datalake/cache.ts | Adds cache enabled method and stream cleanup in streamToBuffer function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lexiv0re
approved these changes
Aug 19, 2025
haiodo
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.