Skip to content

Fix some issues with livekit connection #9690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haiodo merged 3 commits into from
Aug 19, 2025
Merged

Fix some issues with livekit connection #9690

haiodo merged 3 commits into from
Aug 19, 2025

Conversation

@utkaka
Copy link
Contributor

@utkaka utkaka commented Aug 19, 2025 •
edited
Loading

  • Get WorkspaceUuid from metadata instead of store, @aonnikov reported an error:
image - love.metadata.WebSocketURL metadata can be set after LiveKitClient creation, so we need to pass it on connection attempt and shouldn't store it in LiveKitClient

utkaka added 2 commits August 19, 2025 12:40
@utkaka
Fix some issues with livekit connection
7751932 
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
@utkaka
Fix parameter name
a7b9703 
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
@utkaka utkaka requested a review from aonnikov August 19, 2025 05:49
@utkaka
Fix formatting
4ac38a3 
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
@haiodo haiodo merged commit 45180d4 into develop Aug 19, 2025
15 checks passed
@haiodo haiodo deleted the qfix-livekit-connection-issues branch August 19, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aonnikov aonnikov Awaiting requested review from aonnikov

1 more reviewer

@haiodo haiodo haiodo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@utkaka @haiodo