Qfix: backward compatible multiple desktop updates channels #9687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces backward-compatible support for multiple desktop update channels by adding a new DESKTOP_UPDATES_CHANNELS environment variable while keeping the existing DESKTOP_UPDATES_CHANNEL for compatibility with older desktop versions.
- Added
DESKTOP_UPDATES_CHANNELSenvironment variable across configuration files - Updated fallback logic in desktop application to prefer the new variable
- Maintained backward compatibility with existing
DESKTOP_UPDATES_CHANNEL
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pods/front/src/__start.ts | Adds new DESKTOP_UPDATES_CHANNELS environment variable to the front-end configuration |
| dev/docker-compose.yaml | Updates environment variables to use single channel for legacy variable and multiple channels for new variable |
| dev/docker-compose.min.yaml | Updates environment variables to use single channel for legacy variable and multiple channels for new variable |
| desktop/src/ui/types.ts | Adds new DESKTOP_UPDATES_CHANNELS type definition with deprecation comment for old variable |
| desktop/src/main/start.ts | Updates fallback logic to check new variable before falling back to deprecated one |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aonnikov
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.