UBERF-13124: Format hulygram phone number #9686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements phone number formatting functionality for the Telegram integration. It adds a dedicated PhoneInput component that automatically formats phone numbers as users type, replacing basic EditBox inputs with proper phone number validation and formatting.
- Added PhoneInput component with libphonenumber-js for formatting and validation
- Updated Connect and Reconnect components to use PhoneInput instead of EditBox
- Enhanced EditBox component with optional formatter function support
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| PhoneInput.svelte | New component implementing phone number formatting and validation logic |
| Connect.svelte | Updated to use PhoneInput component and libphonenumber-js validation |
| Reconnect.svelte | Replaced EditBox with PhoneInput for phone number input |
| package.json | Added libphonenumber-js dependency for phone number handling |
| EditBox.svelte | Added optional formatter function parameter to support custom formatting |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Artem Savchenko <armisav@gmail.com>
aonnikov
approved these changes
Aug 18, 2025
kristina-fefelova
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.