UBERF-13123: Fix mail message duplicates #9684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a solution to prevent mail message duplicates by introducing an LRU cache to track sent messages and improve Message-ID handling. The fix addresses the UBERF-13123 issue by ensuring messages are only sent once and implementing proper email Message-ID generation and parsing.
Key changes include:
- Added LRU cache in MailWorker to track sent messages and prevent duplicates
- Implemented proper email Message-ID generation and parsing utilities
- Enhanced message handling to use standardized Message-ID format
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| services/mail/pod-mail-worker/src/mailWorker.ts | Added LRU cache for duplicate detection and enhanced message sending logic |
| services/mail/pod-mail-worker/src/handlerMta.ts | Refactored to use new MailHeader enum and email ID generation utilities |
| services/mail/pod-mail-worker/package.json | Added lru-cache dependency |
| services/mail/mail-common/src/utils.ts | Implemented email Message-ID conversion utilities and helper functions |
| services/mail/mail-common/src/types.ts | Added MailHeader enum and updated MessageData interface |
| services/mail/mail-common/src/message.ts | Updated message creation to use new ID conversion logic |
| services/mail/mail-common/src/tests/utils.test.ts | Added comprehensive test coverage for new utility functions |
| services/gmail/pod-gmail/src/message/v2/send.ts | Updated to use new Message-ID generation utility |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
…nto UBERF-13123/fix-duble-mail
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
haiodo
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.