Select space for telegram channel #9681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ArtyomSavchenko
commented
Aug 15, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the channel access control (public/private) with space selection for Telegram channels. Users can now select specific spaces (CardSpace or PersonSpace) where Telegram channels will be synchronized, providing more granular control over where messages appear.
- Replaced access dropdown with SpaceSelector component allowing users to choose target spaces
- Updated data structures to store space references instead of access permissions
- Removed access-related filtering and bulk actions from the UI
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/telegram-resources/src/components/Configure.svelte | Replaced access dropdown with SpaceSelector, updated channel configuration logic and removed access-related UI elements |
| plugins/telegram-resources/src/api.ts | Updated TelegramChannelConfig and TelegramChannelData interfaces to use space references instead of access properties |
| plugins/telegram-resources/package.json | Added @hcengineering/card dependency for CardSpace support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Artem Savchenko <armisav@gmail.com>
aonnikov
previously approved these changes
Aug 15, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
aonnikov
approved these changes
Aug 15, 2025
haiodo
approved these changes
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.