fix: datalake upload fixes #9680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aonnikov
commented
Aug 15, 2025
- Validate uploaded file size after upload
- Cache uploaded files only after successful upload
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with the datalake upload process by implementing validation of uploaded file sizes and ensuring files are only cached after successful upload. The changes address reliability concerns by verifying upload integrity before marking files as successfully stored.
- Modified S3 bucket interface to return void instead of S3Object for put operations
- Added post-upload validation to verify file size matches expected size
- Moved cache operations to occur only after successful upload validation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| services/datalake/pod-datalake/src/s3/types.ts | Changed put method return type from S3Object to void |
| services/datalake/pod-datalake/src/s3/bucket.ts | Updated put implementation to return void and removed S3Object construction |
| services/datalake/pod-datalake/src/handlers/blob.ts | Improved error handling for file stream creation |
| services/datalake/pod-datalake/src/datalake/datalake.ts | Added upload validation and moved caching after successful upload |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
lexiv0re
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.