Office: refactor livekit logic #9679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the LiveKit video conferencing integration by extracting connection management into a dedicated LiveKitClient class, improving code organization and adding several meeting experience enhancements. Key changes include separating LiveKit logic from general office functionality, eliminating duplicate code between components, and introducing user experience improvements for meetings.
- Centralized LiveKit connection management through a new
LiveKitClientclass - Refactored participant views into reusable components
ParticipantsListViewandParticipantView - Added meeting enhancements: poor connection indicators, emoji reactions, and auto-disconnect notification when alone
Reviewed Changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/love-resources/src/liveKitClient.ts | New LiveKit client class for centralized connection management and meeting lifecycle |
| plugins/love-resources/src/utils.ts | Refactored to use centralized LiveKit client, removed duplicate logic |
| plugins/love-resources/src/components/meeting/ParticipantView.svelte | New reusable participant view component with connection quality indicators |
| plugins/love-resources/src/components/meeting/ParticipantsListView.svelte | New component for managing participant lists across different views |
| plugins/love-resources/src/components/meeting/ScreenSharingView.svelte | New dedicated screen sharing component |
| plugins/love-resources/src/components/meeting/Reaction.svelte | New reaction animation component for emoji reactions |
| plugins/love/src/plugin.ts | Added new sound asset for meeting end notifications |
| plugins/love-resources/package.json | Updated livekit-client dependency to 2.15.5 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
haiodo
previously approved these changes
Aug 18, 2025
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com> # Conflicts: # common/config/rush/pnpm-lock.yaml
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
haiodo
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.