Fix Huly mail headers format #9676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the mail headers format by updating the type definition for MailMessage.headers to support multiple header formats and introduces a new function to return headers as a record instead of an array.
- Updated
MailMessage.headerstype to support both record and array formats with flexible value types - Created new
getMailHeadersRecordfunction that returns headers as aRecord<string, string> - Updated mail worker to use the new header function for consistent record format
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
services/mail/pod-mail-worker/src/types.ts |
Defines new Headers type and updates MailMessage.headers property type |
services/mail/pod-mail-worker/src/mailWorker.ts |
Updates import and function call to use new getMailHeadersRecord function |
services/mail/mail-common/src/utils.ts |
Adds new getMailHeadersRecord function that returns headers as a record |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Artem Savchenko <armisav@gmail.com>
aonnikov
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.