UBERF-13120: Support SMTP mail for different accounts #9674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for SMTP mail authentication using different user accounts by allowing dynamic SMTP credentials to be passed per email request. The implementation adds caching for SMTP transporters to improve performance when multiple emails are sent using the same credentials.
Key changes:
- Added password parameter to email sending flow for per-request SMTP authentication
- Implemented LRU cache for SMTP transporters to avoid recreating connections
- Extended account client to fetch mailbox secrets for authentication
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| services/mail/pod-mail/src/transport.ts | Renamed getTransport to getDefaultTransport and added getSmtpTransport for custom credentials |
| services/mail/pod-mail/src/main.ts | Added password parameter extraction and passing to sendMessage |
| services/mail/pod-mail/src/mail.ts | Implemented transporter caching and credential-based transporter selection |
| services/mail/pod-mail/src/tests/main.test.ts | Updated tests to include password parameter |
| services/mail/pod-mail/package.json | Added lru-cache dependency |
| services/mail/pod-mail-worker/src/send.ts | Added secret parameter to sendEmail function |
| services/mail/pod-mail-worker/src/mailWorker.ts | Integrated mailbox secret retrieval and caching |
| server/account/src/operations.ts | Added getMailboxSecret method |
| packages/account-client/src/types.ts | Defined MailboxSecret interface |
| packages/account-client/src/client.ts | Added getMailboxSecret method to AccountClient |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ith insufficient computational effort Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
aonnikov
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.