Do not notify about new messages in initial Gmail sync #9673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Gmail integration to prevent notifications for messages during the initial sync process, while still allowing notifications for subsequent updates.
- Adds a
SyncOptionsparameter to message saving methods to control notification behavior - Implements tracking of the last sync date to differentiate between initial sync and incremental updates
- Updates the sync logic to disable notifications during the first sync but enable them for follow-up syncs
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/gmail/pod-gmail/src/message/v2/message.ts | Adds SyncOptions parameter to saveMessage method in V2 message manager |
| services/gmail/pod-gmail/src/message/v1/message.ts | Adds SyncOptions parameter to saveMessage method in V1 message manager |
| services/gmail/pod-gmail/src/message/types.ts | Updates IMessageManager interface to include optional SyncOptions parameter |
| services/gmail/pod-gmail/src/message/syncState.ts | Adds methods to track last sync date for determining initial vs incremental syncs |
| services/gmail/pod-gmail/src/message/sync.ts | Implements logic to disable notifications during initial sync and pass options through sync methods |
| services/gmail/pod-gmail/src/tests/sync.test.ts | Updates test expectations to match new method signatures with SyncOptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
aonnikov
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.