UBERF-13118: Send emails from Huly mail threads #9669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to send emails from Huly mail threads, extending the mail system to support bidirectional email communication. The primary purpose is to enable sending Huly messages as emails through the mail infrastructure.
- Renamed and restructured the inbound mail service to a more comprehensive mail worker
- Added outgoing email functionality with queue-based message processing
- Integrated email headers to prevent mail loops and identify Huly-generated messages
Reviewed Changes
Copilot reviewed 29 out of 46 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| services/mail/pod-mail/src/main.ts | Enhanced validation and error logging for mail sending API |
| services/mail/pod-mail-worker/src/mailWorker.ts | New mail worker for processing outgoing Huly messages as emails |
| services/mail/pod-mail-worker/src/send.ts | Email sending functionality via HTTP API |
| services/mail/pod-mail-worker/src/workspaceClient.ts | Workspace client management with connection pooling |
| services/mail/pod-mail-worker/src/types.ts | Type definitions for mail messages and constants |
| services/mail/mail-common/src/utils.ts | Shared utilities for mail headers and Huly message detection |
| services/mail/mail-common/src/types.ts | Common type definitions and header constants |
| services/mail/mail-common/src/txHandler.ts | Transaction handling and recipient resolution logic |
| services/mail/mail-common/src/thread.ts | Thread lookup service with email-specific keys |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Artyom Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
aonnikov
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.