Fix EQMS-1630: Separator resize logic #9662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Platov <alexander.platov@hardcoreeng.com>
|
Connected to Huly®: UBERF-13115 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the separator resize logic by correcting inaccurate diff calculation and indexing issues in the resizeDocument function. The changes ensure proper index calculation when resizing separators and improve the accuracy of size calculations.
- Fixed index calculation for accessing separator elements and rects during resize operations
- Improved diff calculation logic to use actual crop amounts instead of available crop amounts
- Corrected size unit conversion by using
pxToRemwhen updating separator sizes
aonnikov
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed inaccurate diff calculation and indexing in resizeDocument