UBERF-11664 Use LRU cache in Datalake #9658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: UBERF-13043 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces LRU caching functionality to the Datalake service to improve performance by caching frequently accessed blob data and processed images.
- Adds configurable LRU cache with environment variable controls for cache size and blob count limits
- Implements blob-level caching in the main datalake operations (get/put)
- Adds image transformation caching to avoid reprocessing images with the same parameters
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| services/datalake/pod-datalake/src/server.ts | Passes cache configuration to DatalakeImpl constructor |
| services/datalake/pod-datalake/src/handlers/image.ts | Implements image transformation result caching with LRU cache |
| services/datalake/pod-datalake/src/datalake/index.ts | Exports cache-related functionality |
| services/datalake/pod-datalake/src/datalake/datalake.ts | Integrates LRU cache into blob storage operations |
| services/datalake/pod-datalake/src/datalake/cache.ts | Implements cache abstraction with LRU and no-op implementations |
| services/datalake/pod-datalake/src/config.ts | Adds cache configuration with environment variable parsing |
| services/datalake/pod-datalake/package.json | Adds lru-cache dependency |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
haiodo
previously approved these changes
Aug 11, 2025
BykhovDenis
previously approved these changes
Aug 11, 2025
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
ef39403 to
6cf1801
Compare
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
6cf1801 to
36b22eb
Compare
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
lexiv0re
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.